[Backport] Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776 #18739

vpodorozh · 2018-10-22T12:13:36Z

Original Pull Request

Description (#16069)

Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes"

Fixed Issues

Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes"

Preconditions

Magento CE 2.2.2 with Sample Data
PHP 7.0

Manual testing scenarios

Create configurable product with view simples
Make configurable and all simple products out of stock
Set Display Out of Stock Products to "yes"

Expected result

Price for configurable product should be displayed

Actual result

Price is not displayed at all

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - allow "out of stock" items to be used for price determination of configurable product ONLY in case all child products are "out of stock".

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - add strict types.

…agento#16069

vpodorozh · 2018-10-22T12:14:22Z

@novikor - please review

novikor

Please add a blank line (comment is left near needed piece of code).

...de/Magento/ConfigurableProduct/Model/ResourceModel/Product/Type/Configurable/StockStatus.php

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - refactor variable names.

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - add blank space.

orlangur · 2018-10-22T13:36:45Z

app/code/Magento/Catalog/Pricing/Render/FinalPriceBox.php

+     */
+    protected function isApplySalableCheck(SaleableInterface $salableItem): bool
+    {
+        return (bool)$salableItem;


Object will be always converted to true, isn't it?

Yes, I’ve missed it. This method from Catalog module should always return true.
Will change it tomorrow.

In general this method was added to make it possible to skip salable check in child classes without need to rewrite _toHtml method.

@orlangur - I've removed unneeded usage of the variable ( check this https://github.com/magento/magento2/pull/18739/files/f4ec67e5aada173a27586131598d5b24957472d6#diff-5f0a1c702f3ad19b38e301107e2852daR97 ). However, there was a need to add @SuppressWarnings(PHPMD.UnusedFormalParameter) phpdoc for isApplySalableCheck method to make it pass static tests.

Goal of this method isApplySalableCheck: make price rendering depending not only on isSalable check but also on addaitional check that can be modified in child classes without need to rewrite _toHtml method.
I've used this "newly added" posibility in this class Magento\ConfigurableProduct\Pricing\Render\FinalPriceBox

An other way to achieve this goal is to rewrite _toHtml method that will require a big amount of copy&paste code due to private properties and methods usage.

So I do prefer currently implemented solution.

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - remove unneeded usage of the variable.

magento-engcom-team · 2018-10-22T18:36:11Z

Hi @vpodorozh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-cicd2 · 2018-10-22T18:36:35Z

All committers have signed the CLA.

…ldren are out of stock and even if Display Out of Stock Products is set to "yes"

vpodorozh · 2018-10-23T16:26:25Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-10-23T16:26:28Z

Hi @vpodorozh. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2018-10-23T16:27:06Z

Hi @vpodorozh, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18739//admin
Login: admin Password: 123123q

vpodorozh · 2018-10-23T18:25:21Z

@orlangur - could you please review my PR?

VladimirZaets · 2019-07-10T16:54:01Z

Hi @vpodorozh. The branch 2.2-develop will be closed for contribution from July 15, 2019. Please finish all your Pull Requests till this date, otherwise, they will be closed.
Thanks for collaboration.

orlangur · 2019-07-15T10:53:09Z

Closing as corresponding 2.3 PR is closed.

m2-assistant · 2019-07-15T10:53:11Z

Hi @vpodorozh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

vpodorozh added 3 commits October 22, 2018 09:18

magento#16069: Configurable product price is not displayed if all chi…

b786871

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - add strict types.

Merge remote-tracking branch 'upstream/2.2-develop' into 2.2-develop-m…

3351aa9

…agento#16069

vpodorozh self-assigned this Oct 22, 2018

novikor assigned novikor and vpodorozh and unassigned vpodorozh and novikor Oct 22, 2018

vpodorozh assigned vpodorozh and novikor and unassigned novikor and vpodorozh Oct 22, 2018

novikor requested changes Oct 22, 2018

View reviewed changes

...de/Magento/ConfigurableProduct/Model/ResourceModel/Product/Type/Configurable/StockStatus.php Show resolved Hide resolved

vpodorozh added 2 commits October 22, 2018 16:19

magento#16069: Configurable product price is not displayed if all chi…

d009296

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - refactor variable names.

magento#16069: Configurable product price is not displayed if all chi…

0b19e04

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - add blank space.

orlangur reviewed Oct 22, 2018

View reviewed changes

magento#16069: Configurable product price is not displayed if all chi…

207e2e1

…ldren are out of stock and even if Display Out of Stock Products is set to "yes" - remove unneeded usage of the variable.

magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Oct 22, 2018

magento-engcom-team added Component: Catalog Component: ConfigurableProduct Release Line: 2.2 labels Oct 22, 2018

magento#16069: Configurable product price is not displayed if all chi…

f4ec67e

…ldren are out of stock and even if Display Out of Stock Products is set to "yes"

novikor approved these changes Oct 23, 2018

View reviewed changes

novikor removed their assignment Oct 23, 2018

vpodorozh mentioned this pull request Oct 23, 2018

Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #16069

Closed

vpodorozh mentioned this pull request Oct 24, 2018

Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776

Closed

4 tasks

orlangur self-assigned this Nov 7, 2018

orlangur changed the title ~~2.2 develop #16069~~ [Backport] Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776 Nov 7, 2018

orlangur added the Progress: on hold label Nov 7, 2018

orlangur closed this Jul 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport] Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776 #18739

[Backport] Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776 #18739

vpodorozh commented Oct 22, 2018 •

edited by sivaschenko

vpodorozh commented Oct 22, 2018

novikor left a comment

orlangur Oct 22, 2018

vpodorozh Oct 22, 2018 •

edited

vpodorozh Oct 22, 2018 •

edited

magento-engcom-team commented Oct 22, 2018

magento-cicd2 commented Oct 22, 2018 •

edited

vpodorozh commented Oct 23, 2018

magento-engcom-team commented Oct 23, 2018

magento-engcom-team commented Oct 23, 2018

vpodorozh commented Oct 23, 2018

VladimirZaets commented Jul 10, 2019

orlangur commented Jul 15, 2019

m2-assistant bot commented Jul 15, 2019

[Backport] Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776 #18739

[Backport] Fix for #16069: Configurable product price is not displayed if all children are out of stock and even if Display Out of Stock Products is set to "yes" #18776 #18739

Conversation

vpodorozh commented Oct 22, 2018 • edited by sivaschenko

Original Pull Request

Description (#16069)

Fixed Issues

Preconditions

Manual testing scenarios

Expected result

Actual result

Contribution checklist

vpodorozh commented Oct 22, 2018

novikor left a comment

Choose a reason for hiding this comment

orlangur Oct 22, 2018

Choose a reason for hiding this comment

vpodorozh Oct 22, 2018 • edited

Choose a reason for hiding this comment

vpodorozh Oct 22, 2018 • edited

Choose a reason for hiding this comment

magento-engcom-team commented Oct 22, 2018

magento-cicd2 commented Oct 22, 2018 • edited

vpodorozh commented Oct 23, 2018

magento-engcom-team commented Oct 23, 2018

magento-engcom-team commented Oct 23, 2018

vpodorozh commented Oct 23, 2018

VladimirZaets commented Jul 10, 2019

orlangur commented Jul 15, 2019

m2-assistant bot commented Jul 15, 2019

vpodorozh commented Oct 22, 2018 •

edited by sivaschenko

vpodorozh Oct 22, 2018 •

edited

vpodorozh Oct 22, 2018 •

edited

magento-cicd2 commented Oct 22, 2018 •

edited